search

AICC / CMI-5_Spec_Current

cmi5
http://adlnet.gov
Apache License 2.0
181 stars 91 forks source link

`languagePreference` would be much easier to handle as an array #731

Open brianjmiller opened 3 years ago

brianjmiller commented 3 years ago

This is currently a comma delimited string and it would be much better to capture a list of values in JSON as an array.

thomasturrell commented 3 years ago

I would prefer it if the language preference requirements are removed in the next major release.

Every modern OS allows the user to set their language preference, these preferences are then made available to the applications running on that operating system.

An AU should use the user preferences set in the OS or browser.

I understand the counter argument that a user might be using someone else's device (like at an Internet cafe whilst on holiday) and they might have different language preference from the owner of the device. However I think that is a very rare scenario and it is very simple for the user to change the language in the OS or browser.

brianjmiller commented 3 years ago

I'm not opposed to that.

gavbaa commented 3 years ago

As it stands, the language preference requirement is referring to the wrong place in the xAPI spec (currently it should be pointed to 4.2, and in the future it should be pointed to 5.2.7), but both of those are actually "Language Maps", which is a dictionary, not an array. At very least even if we don't change anything else, I think we should remove the reference to the xAPI spec completely and just say they're RFC5646 language tags.

thomasturrell commented 3 years ago

I think we should remove the reference to the xAPI spec completely and just say they're RFC5646 language tags.

@gavbaa would you open a pull request for this, I think it would be a good change.

MrBillMcDonald commented 9 months ago

Per Feb 16, 2024 meeting