search

AICoE / aicoe-ci

AICoE-CI using TektonCD pipelines and triggers
13 stars 13 forks source link

overlays builds pipeline fails when using Issue Deliver Container Image #115

Open pacospace opened 3 years ago

pacospace commented 3 years ago

Describe the bug Overlays build pipeline fails when run from issue pipeline.

To Reproduce Steps to reproduce the behavior:

  1. Open Issue with Deliver Container Image in Elyra tutorial and see pipeline failing.

Expected behavior Pipeline successfully delivers all overlays builds.

Screenshots

Additional context

pacospace commented 3 years ago

I did some debugging, and it seems base image is not passed to later step. In particular when opening issue for Delivering Container Image the first step to handle configuration does not consider overlays, therefore later steps miss inputs, like base image: Screenshot from 2021-06-22 11-31-40

We can see error in generate task: 

+ '[' -z '' ']'
+ '[' -f Dockerfile ']'
+ '[' -f Containerfile ']'
+ /usr/local/bin/s2i build . --env THAMOS_RUNTIME_ENVIRONMENT= --env THOTH_ADVISE=0 --env THOTH_ERROR_FALLBACK=1 --env THOTH_DRY_RUN=1 --env THAMOS_DEBUG=0 --env THAMOS_VERBOSE=1 --env THOTH_PROVENANCE_CHECK=0 --loglevel=0 --as-dockerfile /gen-source/Containerfile
ERROR: Required value not specified for "builderImage"

and step later fails to give a misleading error, because in reality the ContainerFile has not been created by the previous task

+ buildah bud --storage-driver=overlay --tls-verify=false --layers -f /gen-source/Containerfile -t elyra-aidevsecops-tutorial-166 .
stat /gen-source/Containerfile: no such file or directory
goern commented 3 years ago

/kind bug /priority critical-urgent /assign @harshad16

harshad16 commented 3 years ago

FIxed it with https://github.com/AICoE/aicoe-ci/commit/b4f842a328cc6190cba5b736398bfd04b29bb096 closing it, please reopen if the issue persists.

pacospace commented 3 years ago

@harshad16 does it solve also the overlays build issue when using "Deliver Container Image" issue?

harshad16 commented 3 years ago

no it doesnt , let me re-open this.

goern commented 3 years ago

Blocking: https://github.com/thoth-station/ps-cv/issues/2 Blocking: https://github.com/thoth-station/ps-nlp/issues/3

pacospace commented 3 years ago

Blocking: thoth-station/ps-cv#2 Blocking: thoth-station/ps-nlp#3

Not blocking those, this issue is when someone uses issue Deliver Container Image with overlays builds

goern commented 3 years ago

ACK, thx.

goern commented 3 years ago

is this still valid?

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta commented 2 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

harshad16 commented 2 years ago

yes this is still valid will get this on lifecycle soon /lifecycle frozen