have a way to deploy only one overlay from Pull Request

AICoE / aicoe-ci

AICoE-CI using TektonCD pipelines and triggers

13 stars 13 forks source link

have a way to deploy only one overlay from Pull Request #125

Closed pacospace closed 2 years ago

pacospace commented 3 years ago

Is your feature request related to a problem? Please describe. As Developer,

I have 10 overlays and I open a feature only for one of them, I don't want to create images from PR for all overlays but only for one.

Describe the solution you'd like Alllow user to have /deploy {overlay-name}

Describe alternatives you've considered

Additional context after discussion with @harshad16

Gregory-Pereira commented 2 years ago

Could we use a .dockerignore file (see example) to scope what you are building, allowing for you to create the image for only the features that you are targeting? The problem is that this may become difficult to maintain if multiple people are merging specific features and are not sure what should be included or not included, so some other part would be required to call this a solution. What do you think?

harshad16 commented 2 years ago

cc: @Gregory-Pereira

Thanks for the kind feature requests. we will proceed with the following procedure to provide this feature:

[ ] Gather the overlay_name passed in the issue_comment body as a param with help of the task and use it in the pull-request pipeline.
[ ] Attach the overlay task in the pull-request pipeline.
[ ] Pass the param to the overlay task.
[ ] Extend the overlay task to build upon a single overlay.