AICoE / aicoe-ci

AICoE-CI using TektonCD pipelines and triggers
13 stars 13 forks source link

creating the github-release tekton task #140

Closed Gregory-Pereira closed 2 years ago

Gregory-Pereira commented 3 years ago

linting

Related Issues and Dependencies

This introduces a breaking change

This Pull Request implements

in response to https://github.com/operate-first/opfcli/issues/24 created automated git releases and populate those with artifacts.

Description

implements https://github.com/operate-first/opfcli/pull/44 but pr from a feature branch.

goern commented 3 years ago

/lgtm nice work!

@harshad16 @Gregory-Pereira does it make sense to externalize all the python code in scripts and call them from the yaml? it would make all the things a little bit cleaner, so that we don't have a heavy mixture or Python and YAML code?!

sesheta commented 2 years ago

New changes are detected. LGTM label has been removed.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/AICoE/aicoe-ci/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment