search

AICoE / aicoe-ci

AICoE-CI using TektonCD pipelines and triggers
13 stars 13 forks source link

check the owners file in the repo as well as github association rules #147

Closed Gregory-Pereira closed 2 years ago

Gregory-Pereira commented 2 years ago

Related Issues and Dependencies

The issue is that permissions are only checked by a developer's access to GitHub organizations, but we want the ability to easily modify and add privileges to others to make changes.

Additionally, ran pre-commit and linted the sesheta request issue template so that the pre-commit check can pass.

This introduces a breaking change

This Pull Request implements

After receiving the response on the PR, the task will now read the owners file and include that in its searching to see if a user has access to the repository.

Description

issue itself still waiting to be created.

Gregory-Pereira commented 2 years ago

/retest

sesheta commented 2 years ago

@Gregory-Pereira: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/AICoE/aicoe-ci/pull/147#issuecomment-956580358): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Gregory-Pereira commented 2 years ago

Local pre-commit passes, ready for review.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/AICoE/aicoe-ci/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harshad16 commented 2 years ago

/unhold