Closed Gregory-Pereira closed 2 years ago
@Gregory-Pereira: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
/remove-hold
Ready for re-review @harshad16.
Prow is having issues, but pre-commit
passes fine locally:
$ pre-commit run -a
Add trailing commas......................................................Passed
Tabs remover.............................................................Passed
Trim Trailing Whitespace.................................................Passed
Check for merge conflicts................................................Passed
Fix End of Files.........................................................Passed
Check for added large files..............................................Passed
check BOM - deprecated: use fix-byte-order-marker........................Passed
Check for case conflicts.................................................Passed
Check Yaml...............................................................Passed
Check for broken symlinks............................(no files to check)Skipped
Detect Private Key.......................................................Passed
pre-commit passes locally. /retest
@Gregory-Pereira: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: harshad16
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
Tests were failing because I forgot to rebase with new changes to AICOE.
Related Issues and Dependencies
AICOE/aicoe-ci issue 125
This introduces a breaking change
This Pull Request implements
The ability to build only one overlay at a time with the /deploy command
… Explain your changes.
Extended the pull-request pipeline with the ability to root through the .aicoe-ci.yaml file looking for overlays, and to deploy the single overlay that matches the overlay name from the pull request comment. Added additional debug step to the init-task to verify the new results that are being produced in that step. Fixed contribution logic to allow contributions from Github owners or members.
Additional notes that came up in the process of testing:
/manifests
directory in the repo to find imagestreamtag.yaml file and updating it, if we have overlays in other repositories without a manifests directory or in this structure, it will need rework.