search

AICoE / aicoe-ci

AICoE-CI using TektonCD pipelines and triggers
13 stars 13 forks source link

Clean up unused Tasks #158

Closed codificat closed 2 years ago

codificat commented 2 years ago

This introduces a breaking change

Hopefully not

This Pull Request implements

This removes a few Task definitions that are not referenced anywhere in the pipelines as far as I could see.

Description

I used this to find the unused tasks:

grep -hrA1 taskRef | grep name | cut -d: -f2 | sed -e 's/ //' | sort -u > used-tasks.txt
grep -rwl Task | xargs -i faq -r .metadata.name {} | sort -u > all-tasks.txt
comm -3 {all,used}-tasks.txt

which produced this output (as of d811a1a3747b7f1ed74b94682c238c1dc6014f76):

    build-go-binaries
example-issue
example-pr-checks
git-add-release-artifacts
pr-merge
tag-build
tag-check
tox-check

These are the Task and TaskRun that this PR removes.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from codificat after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/AICoE/aicoe-ci/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codificat commented 2 years ago

I will close that one in favour of the work to be done in https://github.com/thoth-station/helm-charts/issues/31