AICoE / aicoe-ci

AICoE-CI using TektonCD pipelines and triggers
13 stars 13 forks source link

Help with Sesheta invite #181

Closed MichaelTiemannOSC closed 1 year ago

MichaelTiemannOSC commented 2 years ago

GitHub Repo

https://github.com/os-climate/essd-ingest-pipeline/

harshad16 commented 1 year ago

@MichaelTiemannOSC please send a request to user https://github.com/sesheta for this repo. we this issue will look for the invite and accept it.

MichaelTiemannOSC commented 1 year ago

I'm sorry, but I don't understand what is means to "send a request to [a] user". I know how to file issues, make pull requests, assign resources and labels, etc. But not how to send a request.

harshad16 commented 1 year ago

That alright , i can help you with this before we invite the sesheta to be the contributor can you please confirm, this is in regards with image build for the repo? or is it regarding something else?

MichaelTiemannOSC commented 1 year ago

I want to be able to put an image on Quay that can be used for automating notebook pipelines. Vincent Caldeira has suggested that I really should be building images to run in Airflow, not Elyra, if that matters. But in any case, it will be something derived from an AICoE Dockerfile, with python module dependencies appropriate for use in OS-Climate.

harshad16 commented 1 year ago

ack, sesheta is already a member of os-climate org. For the build process, now we are just missing build details:

Base image: As you said airflow could be something that you would like to use, we dont have any image for airflow , so that would be upto which base image to use. if you would like something based on elyra use: quay.io/thoth-station/s2i-elyra-custom-notebook:latest Update this value with the selected base image: https://github.com/os-climate/essd-ingest-pipeline/blob/6a9cfc512097e5678c2e9b66d8bb46a83754497d/.aicoe-ci.yaml#L10

Build strategy: s2i and dockerfile both are allowed. Update this value with the selected option: https://github.com/os-climate/essd-ingest-pipeline/blob/6a9cfc512097e5678c2e9b66d8bb46a83754497d/.aicoe-ci.yaml#L8 If prefered dockerfile switch with these line: https://github.com/AICoE/aicoe-ci/blob/master/docs/.aicoe-ci.yaml#L11-L12

Quay repo: you would have to create a repo in os-climate quay org. like this https://quay.io/repository/os-climate/aicoe-osc-demo?tab=tags in the setting of the repo, you would have to select the os-climate-pusher bot from dropdown under the section robot premission with write access and update the https://github.com/os-climate/essd-ingest-pipeline/blob/master/.aicoe-ci.yaml#L11-L14 similar to https://github.com/os-climate/aicoe-osc-demo/blob/master/.aicoe-ci.yaml#L11-L14

Line https://github.com/os-climate/essd-ingest-pipeline/blob/6a9cfc512097e5678c2e9b66d8bb46a83754497d/.aicoe-ci.yaml#L9 can be removed it is if user want to run custom script when using s2i. After these setting , all is set for custom build on each github tag creation.

sesheta commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta commented 1 year ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 1 year ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 1 year ago

@sesheta: Closing this issue.

In response to [this](https://github.com/AICoE/aicoe-ci/issues/181#issuecomment-1409095681): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.