search

AICoE / aicoe-ci

AICoE-CI using TektonCD pipelines and triggers
13 stars 13 forks source link

registry-secret replacment in overlay build #187

Closed goern closed 1 year ago

goern commented 1 year ago

Signed-off-by: Christoph Görn goern@redhat.com

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from goern by writing /assign @goern in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/AICoE/aicoe-ci/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
goern commented 1 year ago

This PR might be a fix for https://github.com/b4mad/racing/pull/113#issuecomment-1330341547

/assign @harshad16 /assign @Gregory-Pereira

goern commented 1 year ago

/close this in favor of #190 and #189

sesheta commented 1 year ago

@goern: Closed this PR.

In response to [this](https://github.com/AICoE/aicoe-ci/pull/187#issuecomment-1331838635): >/close >this in favor of #190 and #189 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.