search

AICoE / aicoe-sre

This repository serves as a central location for services being run by the AICoE SRE team.
GNU General Public License v3.0
4 stars 12 forks source link

Add aggregated cluster roles for Argo and Argo Events #34

Closed tumido closed 4 years ago

tumido commented 4 years ago

Aggregated cluster roles allows Argo CD to discover CRDs on namespaces where it has admin/edit/view access without a need to define any additional per overlay/namespace roles, therefore it won't fail when discovering these resources in namespaces which don't plan on using these CRDs - therefore won't define any special roles for them.

sesheta commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign hemajv You can assign the PR to them by writing /assign @hemajv in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/AICoE/aicoe-sre/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
HumairAK commented 4 years ago

lgtm