search

AICoE / aicoe-sre

This repository serves as a central location for services being run by the AICoE SRE team.
GNU General Public License v3.0
4 stars 12 forks source link

Fix Argo[-events] role bindings apiGroup #41

Closed tumido closed 4 years ago

tumido commented 4 years ago

Mixing authorization.openshift.io and rbac.authorization.k8s.io apiGroups causes issues for rolebindings accessing namespaced roles. This PR fixes argo and argo events rolebinding deployments.

Note: this doesn't fix role creation failures - that is caused by missing permissions in project admin cluster roles - project admin can't grant permissions it doesn't have. This will be solved via PSI ticket.

tumido commented 4 years ago

Project admin permissions should be solved via https://redhat.service-now.com/surl.do?n=RITM0737980 ticket

tumido commented 4 years ago

cc @anishasthana @HumairAK please review

sesheta commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/AICoE/aicoe-sre/blob/master/OWNERS)~~ [anishasthana] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment