search

AICoE / aicoe-sre

This repository serves as a central location for services being run by the AICoE SRE team.
GNU General Public License v3.0
4 stars 12 forks source link

Add custom profile for shanand user and reorder custom profiles #49

Closed rimolive closed 4 years ago

rimolive commented 4 years ago

This change was necessary based on some experiments that profiles are matched sequencially.

That way, if you have a custom user profile that changes spark cluster configuration, the latter image profiles that does the same changes will be applied.

The order that must be followed should be: global profile -> image-specific profiles -> user-specific profiles.

sesheta commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign hemajv You can assign the PR to them by writing /assign @hemajv in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/AICoE/aicoe-sre/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rimolive commented 4 years ago

/assign @hemajv

anishasthana commented 4 years ago

@rimolive The PR actually had to go to https://github.com/AICoE/idh-manifests/pulls :-)