search

AICoE / prometheus-anomaly-detector

A newer more updated version of the prometheus anomaly detector (https://github.com/AICoE/prometheus-anomaly-detector-legacy)
GNU General Public License v3.0
597 stars 151 forks source link

Make it clear where /metrics will be available. #141

Closed kiefersmith closed 3 years ago

kiefersmith commented 3 years ago

I assumed /metrics was available on port 8080, but it is not immediately apparent.

Also, I was thinking it might be nicer to expose this port in the Dockerfile. It makes deployment easier in situations where exposing with docker run -p ... is not available. Prometheus itself does this among others. Avoids having to build the image again with an EXPOSE term.

Happy holidays!

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 4n4nd To complete the pull request process, please assign after the PR has been reviewed. You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/AICoE/prometheus-anomaly-detector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
4n4nd commented 3 years ago

Thanks @kiefersmith 👍