search

AICoE / prometheus-anomaly-detector

A newer more updated version of the prometheus anomaly detector (https://github.com/AICoE/prometheus-anomaly-detector-legacy)
GNU General Public License v3.0
597 stars 151 forks source link

Add ability to ignore labels #155

Closed HumairAK closed 2 years ago

HumairAK commented 3 years ago

The way I understand it, PAD will need to be restarted whenever a label updates. This is an issue for when dealing with metrics that contain pod names as a label for example. If the pod has a generated suffix, a new one is generated upon each restart, thus requiring pad to be restarted, and being unable to leverage the old pod's historical data (iiuc).

It would be nice if I could pass a flag or file with a list of labels to ignore :)

4n4nd commented 3 years ago

This is a great suggestion. I think we could add a new flag something like FLT_IGNORE_LABEL_CHANGES="pod_name, pod_ip" and it would ignore the changes in those specific labels.

sesheta commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 2 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 2 years ago

@sesheta: Closing this issue.

In response to [this](https://github.com/AICoE/prometheus-anomaly-detector/issues/155#issuecomment-995046390): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.