AICoE / s2i-custom-notebook

An s2i container image for JupyterHub with custom notebooks and dependencies
GNU General Public License v3.0
4 stars 12 forks source link

Some missing info into the doc for building image locally #11

Closed pacospace closed 4 years ago

pacospace commented 4 years ago

Is your feature request related to a problem? Please describe. If I'm a new user of the s2i-custom-notebook and I try to build my image locally using the command listed in the doc I don't see mention about:

Maybe a better soluton is to add some alternative description using podman/buildah. it would be nice.

4n4nd commented 4 years ago

This error might mean the Docker service is not running.

But I think I get the point here, we need more instructions introducing s2i and image building stuff.

pacospace commented 4 years ago

This error might mean the Docker service is not running.

But I think I get the point here, we need more instructions introducing s2i and image building stuff.

Yes the error is the Docker Deamon not running, but is more to have a general doc for the command. Thanks @4n4nd

SankBad commented 4 years ago

Is there any update on this issue? I am trying to install s2i.

When I am running the command: $ go get github.com/openshift/source-to-image/cmd/s2i

I am getting the error:

Package devmapper was not found in the pkg-config search path.
Perhaps you should add the directory containing devmapper.pc
to the PKG_CONFIG_PATH environment variable
Package 'devmapper', required by 'virtual:world', not found
pkg-config: exit status 1
# github.com/openshift/source-to-image/vendor/github.com/containers/storage/drivers/btrfs
go/src/github.com/openshift/source-to-image/vendor/github.com/containers/storage/drivers/btrfs/btrfs.go:8:10: fatal error: btrfs/ioctl.h: No such file or directory
 #include <btrfs/ioctl.h>
          ^~~~~~~~~~~~~~~
compilation terminated.

@4n4nd @harshad16

I am using RHEL 8

harshad16 commented 4 years ago

Is there any update on this issue? I am trying to install s2i.

When I am running the command: $ go get github.com/openshift/source-to-image/cmd/s2i

Did you try installation via available tar for Linux system. https://github.com/openshift/source-to-image#for-linux if the issue is happening in the installation via go. may be pointing the question to https://github.com/openshift/source-to-image might be helpful.

About the issue of updating doc for the build, it for the non-root user using s2i directly with docker. docker deamon is to be set to have this configuration fixed. will updated the docs for this.

SankBad commented 4 years ago

Thanks @4n4nd @harshad16 installation using tar is working.

MichaelClifford commented 4 years ago

PR #36 adds some additional documentation about local builds that I think should address this issue.

harshad16 commented 4 years ago

Thanks @MichaelClifford for the updates.

harshad16 commented 4 years ago

Seems like with commit from @MichaelClifford it covers the setup and build with s2i concept. Closing this issue, Please re-open a new issue if needed.