search

AICoE / s2i-custom-notebook

An s2i container image for JupyterHub with custom notebooks and dependencies
GNU General Public License v3.0
4 stars 12 forks source link

make notebook folder configurable #13

Open durandom opened 4 years ago

durandom commented 4 years ago

If you start many content notebook images, you'll end up with a bunch of notebooks-<date> folders. Can we start with naming the folder after the repo that the image was built from? So that https://gitlab.cee.redhat.com/AICoE/ocp4/ results in ocp4-<date> ? Actually thinking about it, it might be more straight forward to add a simple config .notebooks.yaml into the notebooks folder that configures exactly this. That way we can sneak in more control over the build and deploy process.

notebooks_folder_name: "notebooks"
4n4nd commented 4 years ago

@durandom this has already been implemented. Did it not work for you?

durandom commented 4 years ago

I just saw that we name the folder after the git repo. Implemeted via https://github.com/AICoE/s2i-custom-notebook/pull/5/files

That's good. I guess I was missing the documentation.

Let's keep this issue still open, maybe we want to make it configurable.

sesheta commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

harshad16 commented 3 years ago

/lifecycle frozen /priority backlog