AICoE / s2i-custom-notebook

An s2i container image for JupyterHub with custom notebooks and dependencies
GNU General Public License v3.0
4 stars 12 forks source link

[WIP] Update README.md #34

Closed 4n4nd closed 4 years ago

4n4nd commented 4 years ago

This introduces a breaking change

This Pull Request implements

Add instruction to build directly from repo url

sesheta commented 4 years ago
Pre-Commit Test failed! Click here ``` [INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://gitlab.com/PyCQA/flake8. [INFO] Initializing environment for https://gitlab.com/PyCQA/flake8:pep8-naming. [INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://gitlab.com/PyCQA/flake8. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing README.md Check for merge conflicts................................................Passed Fix End of Files.........................................................Passed Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed Check for byte-order marker..............................................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed flake8...................................................................Passed ```
harshad16 commented 4 years ago

/approve

sesheta commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/AICoE/s2i-custom-notebook/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
4n4nd commented 4 years ago

Closing since same changes were added in #36

sesheta commented 4 years ago

@4n4nd: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.