AICoE / sefkhet-abwy

This is one of the incarnations of Sesheta
GNU General Public License v3.0
5 stars 13 forks source link

Update project owners and remove maintainers from thoth config #177

Closed codificat closed 2 years ago

codificat commented 2 years ago

Related Issues and Dependencies

Creating this after #173.

There is work in progress to update a few OWNERS files, including the template project: thoth-station/template-project#24

This introduces a breaking change

No

This Pull Request implements

Adds the current team to the list of approvers and reviewers in OWNERS.

Also, let the bot rely on this file instead of duplicating a maintainers list within .thoth.yaml

codificat commented 2 years ago

Updated to only add myself and sync maintainers / approvers / reviewers

codificat commented 2 years ago

Actually... /hold updating again now that https://github.com/thoth-station/kebechet/issues/876 is fixed. This way we can verify it works :innocent:

codificat commented 2 years ago

Updated and ready for review /unhold

codificat commented 2 years ago

This is not urgent, but bumping:

/assign @harshad16

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/AICoE/sefkhet-abwy/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codificat commented 2 years ago

/retest

codificat commented 2 years ago

/test all

codificat commented 2 years ago

/shrug

codificat commented 2 years ago

prow/tide keeps missing to merge this PR for some reason, so I'm merging it manually.

tide logs excerpt

$ oc logs tide-78656ccf44-8kj7b | grep sefkhet-abwy | grep -w 177 | tail -5 | jq .
{
  "branch": "master",
  "component": "tide",
  "context_names": [
    "aicoe-ci/build-check",
    "aicoe-ci/prow/pre-commit",
    "tide"
  ],
  "failed_context_count": 0,
  "failed_context_names": [
    "aicoe-ci/build-check",
    "aicoe-ci/prow/pre-commit",
    "tide"
  ],
  "file": "prow/tide/tide.go:804",
  "func": "k8s.io/test-infra/prow/tide.unsuccessfulContexts",
  "level": "debug",
  "msg": "Filtered out failed contexts",
  "org": "AICoE",
  "pr": 177,
  "repo": "sefkhet-abwy",
  "severity": "debug",
  "sha": "2c8ebbe31d58ba69441afdd2365b388a004c7d01",
  "time": "2021-11-18T09:21:44Z",
  "total_context_count": 3
}
{
  "base-sha": "1fa87f71c4fe01597fbbd8e553d0481b15db1561",
  "branch": "master",
  "component": "tide",
  "controller": "sync",
  "file": "prow/tide/tide.go:1569",
  "func": "k8s.io/test-infra/prow/tide.(*Controller).presubmitsByPull",
  "level": "debug",
  "msg": "Found 1 possible presubmits",
  "org": "AICoE",
  "pr": 177,
  "repo": "sefkhet-abwy",
  "severity": "debug",
  "sha": "2c8ebbe31d58ba69441afdd2365b388a004c7d01",
  "time": "2021-11-18T09:23:14Z"
}
{
  "base-sha": "1fa87f71c4fe01597fbbd8e553d0481b15db1561",
  "branch": "master",
  "component": "tide",
  "context_names": [
    "aicoe-ci/build-check",
    "aicoe-ci/prow/pre-commit",
    "tide"
  ],
  "controller": "sync",
  "failed_context_count": 1,
  "failed_context_names": [
    "aicoe-ci/build-check",
    "aicoe-ci/prow/pre-commit",
    "tide"
  ],
  "file": "prow/tide/tide.go:804",
  "func": "k8s.io/test-infra/prow/tide.unsuccessfulContexts",
  "level": "debug",
  "msg": "Filtered out failed contexts",
  "org": "AICoE",
  "pr": 177,
  "repo": "sefkhet-abwy",
  "severity": "debug",
  "sha": "2c8ebbe31d58ba69441afdd2365b388a004c7d01",
  "time": "2021-11-18T09:23:17Z",
  "total_context_count": 3
}
{
  "base-sha": "1fa87f71c4fe01597fbbd8e553d0481b15db1561",
  "branch": "master",
  "component": "tide",
  "context": "aicoe-ci/pre-commit-check",
  "controller": "sync",
  "file": "prow/tide/tide.go:621",
  "func": "k8s.io/test-infra/prow/tide.filterPR",
  "level": "debug",
  "msg": "filtering out PR as unsuccessful context is not pending",
  "org": "AICoE",
  "pr": 177,
  "repo": "sefkhet-abwy",
  "severity": "debug",
  "sha": "2c8ebbe31d58ba69441afdd2365b388a004c7d01",
  "time": "2021-11-18T09:23:17Z"
}
{
  "branch": "master",
  "component": "tide",
  "context_names": [
    "aicoe-ci/build-check",
    "aicoe-ci/prow/pre-commit",
    "tide"
  ],
  "failed_context_count": 0,
  "failed_context_names": [
    "aicoe-ci/build-check",
    "aicoe-ci/prow/pre-commit",
    "tide"
  ],
  "file": "prow/tide/tide.go:804",
  "func": "k8s.io/test-infra/prow/tide.unsuccessfulContexts",
  "level": "debug",
  "msg": "Filtered out failed contexts",
  "org": "AICoE",
  "pr": 177,
  "repo": "sefkhet-abwy",
  "severity": "debug",
  "sha": "2c8ebbe31d58ba69441afdd2365b388a004c7d01",
  "time": "2021-11-18T09:23:44Z",
  "total_context_count": 3
}