AICoE / sefkhet-abwy

This is one of the incarnations of Sesheta
GNU General Public License v3.0
5 stars 13 forks source link

updates of user ids #190

Closed goern closed 1 year ago

goern commented 2 years ago

Related Issues and Dependencies

standard maintenance of user ids

This introduces a breaking change

codificat commented 2 years ago

There is now a merge conflict here... https://github.com/codificat/sefkhet-abwy/commit/2fbdc374f355f95d4e5b721649aab0164b94ae38 I believe would fix it, but you might prefer to rebase?

sesheta commented 1 year ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

codificat commented 1 year ago

/lgtm /approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/AICoE/sefkhet-abwy/blob/master/OWNERS)~~ [codificat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codificat commented 1 year ago

Trying to understand why prow is not merging this one... tide logs show:

{
  "base-sha": "ddda9038da7304eb18c26848b14d0b71120c4c3f",
  "branch": "master",
  "component": "tide",
  "context": "aicoe-ci/pre-commit-check",
  "controller": "sync",
  "file": "k8s.io/test-infra/prow/tide/tide.go:693",
  "func": "k8s.io/test-infra/prow/tide.filterPR",
  "level": "debug",
  "msg": "filtering out PR as unsuccessful context is not pending",
  "org": "AICoE",
  "pr": 190,
  "repo": "sefkhet-abwy",
  "severity": "debug",
  "sha": "0e0c7f82f1b824ff36df8bbe9ca0cbcc46aa217b",
  "time": "2022-10-04T11:20:51Z"
}
{
  "base-sha": "ddda9038da7304eb18c26848b14d0b71120c4c3f",
  "branch": "master",
  "component": "tide",
  "controller": "sync",
  "file": "k8s.io/test-infra/prow/tide/tide.go:610",
  "func": "k8s.io/test-infra/prow/tide.(*syncController).filterSubpools.func1",
  "key": "AICoE/sefkhet-abwy:master",
  "level": "debug",
  "msg": "filtering sub-pool removed all PRs",
  "org": "AICoE",
  "pool": null,
  "repo": "sefkhet-abwy",
  "severity": "debug",
  "time": "2022-10-04T11:20:51Z"
}

I am not really sure what this means, but going to try this: /test pre-commit

codificat commented 1 year ago

Well, something is not working right with prow/tide. It keeps reporting failed contexts. Well, it reports 1 failed context, and lists 3:

{
  "base-sha": "ddda9038da7304eb18c26848b14d0b71120c4c3f",
  "branch": "master",
  "component": "tide",
  "context_names": [
    "aicoe-ci/build-check",
    "aicoe-ci/prow/pre-commit",
    "tide"
  ],
  "controller": "sync",
  "failed_context_count": 1,
  "failed_context_names": [
    "aicoe-ci/build-check",
    "aicoe-ci/prow/pre-commit",
    "tide"
  ],
  "file": "k8s.io/test-infra/prow/tide/tide.go:904",
  "func": "k8s.io/test-infra/prow/tide.unsuccessfulContexts",
  "level": "debug",
  "msg": "Filtered out failed contexts",
  "org": "AICoE",
  "pr": 190,
  "repo": "sefkhet-abwy",
  "severity": "debug",
  "sha": "0e0c7f82f1b824ff36df8bbe9ca0cbcc46aa217b",
  "time": "2022-10-04T11:30:14Z",
  "total_context_count": 3
}

-ENOTIME to dig further, going to manually merge