Fix usage of podio pre-processor version checks

AIDASoft / DD4hep

Detector Description Toolkit for High Energy Physics

http://dd4hep.cern.ch

GNU Lesser General Public License v3.0

49 stars 95 forks source link

Closed tmadlener closed 5 months ago

tmadlener commented 5 months ago

BEGINRELEASENOTES

DDDigiEDM4hep: Switch to the correct podio pre-processor version checks for switching to the non-deprecated readers / writers. Also simplify this such that choosing which type(name) to use is handled in one place rather than several.
Geant4Output2EDM4hep: Switch to a non-deprecated setter for setting the MCParticle for a SimTrackerHit once EDM4hep ships with it.

ENDRELEASENOTES

github-actions[bot] commented 5 months ago

14 files 14 suites 7h 43m 42s :stopwatch: 363 tests 362 :white_check_mark: 0 :zzz: 1 :x: 2 496 runs 2 495 :white_check_mark: 0 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit 2b04762f.

:recycle: This comment has been updated with latest results.

tmadlener commented 5 months ago

The failing tests seem unrelated to these changes(?)

andresailer commented 5 months ago

Yes, t_ClientTests_sim_SiliconBlockGFlash_LONGTEST has been failing since some Geant4 update in the stacks. Only fails in G4 units

andresailer commented 5 months ago

Good to merge?

tmadlener commented 5 months ago

Just added back an include that I removed accidentally. Otherwise, yes.