AIDASoft / DD4hep

Detector Description Toolkit for High Energy Physics
http://dd4hep.cern.ch
GNU Lesser General Public License v3.0
47 stars 93 forks source link

Geant4GFlashShowerModel: remove wrong unit conversions from particleBound properties #1255

Closed andresailer closed 3 months ago

andresailer commented 3 months ago

BEGINRELEASENOTES

ENDRELEASENOTES

The reason why the test failed was that nan showed up in the position of the hit. This nan comes originally from here

https://github.com/Geant4/geant4/blob/dda54bbdcfe0cc76177eaa03a657592aac0b1eb8/source/parameterisations/gflash/src/GFlashHomoShowerParameterisation.cc#L177

Why we only saw this sometimes is not clear. If this is related to the particle bounds, or if we were just lucky before, or something systematic in the functions.

github-actions[bot] commented 3 months ago

Test Results

   14 files     14 suites   6h 36m 29s :stopwatch:   363 tests   363 :white_check_mark: 0 :zzz: 0 :x: 2 496 runs  2 496 :white_check_mark: 0 :zzz: 0 :x:

Results for commit ab79dd7d.