AIDASoft / DD4hep

Detector Description Toolkit for High Energy Physics
http://dd4hep.cern.ch
GNU Lesser General Public License v3.0
47 stars 93 forks source link

DDSim: correct the number of events when running over all events (-1) #1258

Closed andresailer closed 2 months ago

andresailer commented 2 months ago

BEGINRELEASENOTES

ENDRELEASENOTES

github-actions[bot] commented 2 months ago

Test Results

   14 files     14 suites   7h 4m 55s :stopwatch:   363 tests   363 :white_check_mark: 0 :zzz: 0 :x: 2 496 runs  2 496 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 991228de.

:recycle: This comment has been updated with latest results.

MarkusFrankATcernch commented 2 months ago

@andresailer In principle there is a property Geant4Kernel::NumEvents, which defines the number of events to be processed. This property is then passed to Geant4Exec, where the G4 machinery is invoked. Does this property not work or is this not sufficient to do the computation?

andresailer commented 2 months ago

@andresailer In principle there is a property Geant4Kernel::NumEvents, which defines the number of events to be processed. This property is then passed to Geant4Exec, where the G4 machinery is invoked. Does this property not work or is this not sufficient to do the computation?

But here the number of events to be processed is going to be -1, so I want to check the actual counter of events processed.

MarkusFrankATcernch commented 2 months ago

@andresailer Correct. Then this approach looks correct.

andresailer commented 2 months ago

Thanks @MarkusFrankATcernch