GeoHandler: store shapes in deterministic order

AIDASoft / DD4hep

Detector Description Toolkit for High Energy Physics

http://dd4hep.cern.ch

GNU Lesser General Public License v3.0

47 stars 93 forks source link

GeoHandler: store shapes in deterministic order #1277

Closed andresailer closed 1 month ago

andresailer commented 1 month ago

From #1271, I am not sure which of these sets causes the problem, so this is an attempt to get the ball rolling.

BEGINRELEASENOTES

Geant4Converter: fix the order of the TGeoNode conversion to Geant4 volumes, using vector instead of set. Maybe fixes #1271

ENDRELEASENOTES

github-actions[bot] commented 1 month ago

Test Results

14 files 14 suites 7h 5m 1s :stopwatch: 363 tests 363 :white_check_mark: 0 :zzz: 0 :x: 2 496 runs 2 496 :white_check_mark: 0 :zzz: 0 :x:

Results for commit d5238cec.

:recycle: This comment has been updated with latest results.

andresailer commented 1 month ago

@MarkusFrankATcernch With this I get identical GDML files for SiD.xml out of Geant4.

The main change is inside m_data from set -> vector. The collect function actually did the "scan" over the geometry, the other sets in GeometryInfo seem not important.

MarkusFrankATcernch commented 1 month ago

Great. Should we ask Witek to test this branch first ?

andresailer commented 1 month ago

It is apparently too hard to build the LHCb stack to test this. But the GDML comparison with SiD.xml hopefully triggered the same issue. So merging now, tagging tomorrow.