Fix compiling with Clang 18 and a few warnings

AIDASoft / DD4hep

Detector Description Toolkit for High Energy Physics

http://dd4hep.cern.ch

GNU Lesser General Public License v3.0

47 stars 93 forks source link

Fix compiling with Clang 18 and a few warnings #1290

Closed jmcarcell closed 2 weeks ago

jmcarcell commented 2 weeks ago

The header is needed to be able to find ::open and ::close. For the warnings I commented out one case instead of removing it because the place where it's used is also commented out (here, so it would be easy to reenable in case someone wanted to...).

BEGINRELEASENOTES

Add the missing header unistd.h in a file to find ::open and ::close
Fix a few warnings about unused variables or shadowing
Add .cache and compile_commands.json to .gitignore

ENDRELEASENOTES

github-actions[bot] commented 2 weeks ago

Test Results

14 files 14 suites 6h 39m 28s :stopwatch: 365 tests 365 :white_check_mark: 0 :zzz: 0 :x: 2 510 runs 2 510 :white_check_mark: 0 :zzz: 0 :x:

Results for commit e3264a5d.