search

AIDASoft / DD4hep

Detector Description Toolkit for High Energy Physics
http://dd4hep.cern.ch
GNU Lesser General Public License v3.0
49 stars 95 forks source link

GridPhiEta bug #158

Closed whit2333 closed 7 years ago

whit2333 commented 7 years ago

I cannot build since https://github.com/AIDASoft/DD4hep/commit/e47715e83d210e2cab7e128d713fcea29c6cf704

[  1%] Building CXX object DDSegmentation/CMakeFiles/DDSegmentation.dir/src/GridPhiEta.cpp.o
/opt/software/sources/DD4hep/DDSegmentation/src/GridPhiEta.cpp: In member function ‘virtual DD4hep::DDSegmentation::Vector3D DD4hep::DDSegmentation::GridPhiEta::position(const CellID&) const’:
/opt/software/sources/DD4hep/DDSegmentation/src/GridPhiEta.cpp:39:16: error: ‘positionFromREtaPhi’ is not a member of ‘DD4hep::DDSegmentation::Util’
   return Util::positionFromREtaPhi(1.0, eta(), phi());
                ^~~~~~~~~~~~~~~~~~~
/opt/software/sources/DD4hep/DDSegmentation/src/GridPhiEta.cpp:39:16: note: suggested alternative: ‘positionFromRThetaPhi’
   return Util::positionFromREtaPhi(1.0, eta(), phi());
                ^~~~~~~~~~~~~~~~~~~
                positionFromRThetaPhi
/opt/software/sources/DD4hep/DDSegmentation/src/GridPhiEta.cpp: In member function ‘virtual DD4hep::DDSegmentation::CellID DD4hep::DDSegmentation::GridPhiEta::cellID(const DD4hep::DDSegmentation::Vector3D&, const DD4hep::DDSegmentation::Vector3D&, const VolumeID&) const’:
/opt/software/sources/DD4hep/DDSegmentation/src/GridPhiEta.cpp:44:23: error: ‘etaFromXYZ’ is not a member of ‘DD4hep::DDSegmentation::Util’
   double lEta = Util::etaFromXYZ(globalPosition);
                       ^~~~~~~~~~
/opt/software/sources/DD4hep/DDSegmentation/src/GridPhiEta.cpp:44:23: note: suggested alternative: ‘thetaFromXYZ’
   double lEta = Util::etaFromXYZ(globalPosition);
                       ^~~~~~~~~~
                       thetaFromXYZ
jlingema commented 7 years ago

Hi! Not sure why, but it looks to me like you are out of sync with the master branch. The etaFromXYZ is defined here.

whit2333 commented 7 years ago

Not out of sync. Tried with gcc 6.3 and 7.1. Could it be something weird with the inline funtions?

petricm commented 7 years ago

Can you post the exact sequence of commands that results in this, so that we see if we can reproduce this.

whit2333 commented 7 years ago

It looks like the build was seeing headers from the old install. When I remove them the build seems to work now. Sorry about that.

BTW I have noticed the behavior appear in the build ROOT too. Not sure when it started but we used to be able to have version X of ROOT installed while we are building version Y.