AIDASoft / DD4hep

Detector Description Toolkit for High Energy Physics
http://dd4hep.cern.ch
GNU Lesser General Public License v3.0
50 stars 99 forks source link

SetMaxAllowedStep vs SetUserMaxTrackLength in Geant4Converter.cpp? #324

Closed shaojunlu closed 6 years ago

shaojunlu commented 6 years ago

For the "G4UserLimits", Do we really want to "SetMaxAllowedStep" for "track_length_max"? Or do we want to "SetUserMaxTrackLength" for " track_length_max" here? https://github.com/AIDASoft/DD4hep/blob/master/DDG4/src/Geant4Converter.cpp#L867

"SetMaxAllowedStep" for "step_length_max" has been taken care at line 864, right?

gaede commented 6 years ago

Yes, you are right. Markus will fix it.

shaojunlu commented 6 years ago

This issue has been fixed with PR#329 by Markus.