Make it possible to dispose of unconsumed collection buffers

AIDASoft / podio

PODIO

GNU General Public License v3.0

24 stars 60 forks source link

Make it possible to dispose of unconsumed collection buffers #502

Closed tmadlener closed 1 year ago

tmadlener commented 1 year ago

BEGINRELEASENOTES

Add a deleteBuffers function that is populated at generation time to the CollectionReadBuffers to make it possible to dispose of unconsumed buffers. This fixes the main leaks described in #500
Make the ROOTFrameData clean up all unconsumed buffers at desctruction.
Make sure to delete buffers that are no longer necessary in the CollectionData constructor. This fixes some more leaks described in #500

ENDRELEASENOTES

Fixes #500

tmadlener commented 1 year ago

This should fix #500 (still have to test that on a larger scale) but it is a bit cumbersome and the "proper" solution would be to make the CollectionReadBuffers owners of their data and giving them move-only semantics such that the flow of ownership of the data is expressed much more clearly.

I would be happy to merge this as is to fix the current leak and then address the "proper" solution after v1.0, because I am not entirely sure whether it can be made to work with the EventStore.

hegner commented 1 year ago

Is it WIP or are you finished with this now? I am asking because of more commits coming in. Thanks

tmadlener commented 1 year ago

Just finished a few more larger scale tests and valgrind and this fixes the leaks of unconsumed collection buffers.