Closed graeme-a-stewart closed 7 months ago
I would demote the warnings to
STATUS
and also remove theblack
andflake8
target fromall
(if they are part of it), simply to not interfere too much with editor plugins or changing files unexpectedly just from running the build.
all
targetThanks for the suggestions!
I think the CI test failure has nothing to do with this PR, right?
https://github.com/AIDASoft/podio/actions/runs/7638050555/job/20808138304?pr=544#step:4:295
Once this PR is deemed to be in good shape, I will replicate it for https://github.com/key4hep/EDM4hep.
I think the CI test failure has nothing to do with this PR, right?
https://github.com/AIDASoft/podio/actions/runs/7638050555/job/20808138304?pr=544#step:4:295
No, it looks like ROOT has changed something in the RNTuple interface. Specifically, I think it's this PR: https://github.com/root-project/root/pull/14391
Edit: keeping track of this in #545
Add CMake targets for running black and flake8 on Python source files
CMake will look to find the relevant binaries and setup the targets if they are there If they are not found it's a warning (too severe?) Note that current Key4hep nightlies don't have flake8 - if we use another linter that can be substituted
BEGINRELEASENOTES Add CMake targets for running black and flake8 on Python source files ENDRELEASENOTES