Clean up headers with include-what-you-use

AIDASoft / podio

PODIO

GNU General Public License v3.0

24 stars 60 forks source link

Clean up headers with include-what-you-use #567

Open jmcarcell opened 7 months ago

jmcarcell commented 7 months ago

BEGINRELEASENOTES

Clean up headers with include-what-you-use, second part after https://github.com/AIDASoft/podio/pull/652

ENDRELEASENOTES

jmcarcell commented 5 months ago

I added iwyu to the stack and ran it. I think it's not in a state where it can be added to CI. The authors say it's in "alpha" and after playing with it a bit, it needed to add back one include that keeps being removed, doesn't take into account that some includes can only be used with C++20 and for some reason clangd told me there a few headers that could be removed.

m-fila commented 5 months ago

there is also misc-include-cleaner check for clang-tidy, which is supposed to given close results to clangd. And clangd also has CLI tool called clang-include-cleaner

hegner commented 4 months ago

@jmcarcell - can you update this? thanks

tmadlener commented 2 months ago

Will you rebase this PR to do further cleanup after #652? Or should we close this and open a new one?