Make sure that the `as_type` argument is respected for `Frame.put_parameters` for lists of values as well

AIDASoft / podio

PODIO

GNU General Public License v3.0

24 stars 60 forks source link

Make sure that the `as_type` argument is respected for `Frame.put_parameters` for lists of values as well #575

Closed tmadlener closed 7 months ago

tmadlener commented 7 months ago

BEGINRELEASENOTES

Make sure that the as_type argument is respected in Frame.put_parameter also for lists of doubles / floats.
Fix test to actually check for this.

ENDRELEASENOTES

tmadlener commented 7 months ago

The recent updates to cppyy in root mater also broke the resolution of Frame::put from the python side. For some reason I haven't yet figured out it runs into a copy constructor for a unique_ptr which has not been the case before. Marking the argument as rvalue reference makes things work again for root@master.

tmadlener commented 7 months ago

The issue relating to Frame::put has been reported to ROOT here: https://github.com/root-project/root/issues/15117

tmadlener commented 7 months ago

Merging this as it fixes a false positive test and we have to wait for ROOT to see how to fix the other python issue for upcoming versions.