AIDASoft / podio

PODIO
GNU General Public License v3.0
23 stars 57 forks source link

Remove dynamic determination of supported parameter types for python bindings #602

Closed tmadlener closed 2 months ago

tmadlener commented 3 months ago

BEGINRELEASENOTES

ENDRELEASENOTES

Given that the GenericParameter types that we support probably doesn't change very frequently we could also consider keeping the "hardcoded" map as the only implementation and document that this needs to be updated in case the supported parameter types are changed. The current code for determining it is quite a mouthful and I am not sure it's more maintainable than having to update this map manually.

tmadlener commented 2 months ago

I have replaced the dynamic determination with a hardcoded map of types since this will not change very frequently and the code that does the determination is effectively c++ template meta programming with python syntax, which makes maintenance harder than the newly introduced map.