AIDASoft / podio

PODIO
GNU General Public License v3.0
23 stars 57 forks source link

Marking move from one component type to another one as impossible for schema evolution #622

Closed hegner closed 2 months ago

hegner commented 2 months ago

BEGINRELEASENOTES

This addresses #563

hegner commented 2 months ago

This turned out to be a slightly simpler change than what I would have imagined :).

Probably speaks for the design for once :-D

hegner commented 2 months ago

Can we add a simple test that at least runs the script on the example datamodel(s) that we have?

Surprised we didn't have. This PR or a new one?

tmadlener commented 2 months ago

Yeah, I also thought we had one, but at least I couldn't find one. Or if we have one at least it didn't trigger this issue. I would prefer a new PR.

hegner commented 2 months ago

We only had for the C++ part it seems. OK. new ticket, new PR

tmadlener commented 2 months ago

PR to fix the bug in the schema evolution generation: #627

hegner commented 2 months ago

other PR merged now

tmadlener commented 2 months ago

Can you rebase this quickly to pick up those changes?

hegner commented 2 months ago

obviously that fails now ;-) need to change the test definition

hegner commented 2 months ago

for post v1 we could do that a bit separated without a file, but in pure python tests. I will merge now.