Make the TTree and RNTuple based backends write the GenericParameters the same way

AIDASoft / podio

PODIO

GNU General Public License v3.0

23 stars 57 forks source link

Make the TTree and RNTuple based backends write the GenericParameters the same way #625

Closed tmadlener closed 2 months ago

tmadlener commented 2 months ago

BEGINRELEASENOTES

Make the TTree based backend also write the GenericParameters as pairs of vectors (keys and values) to make the format the same for the RNTuple and the TTree based backends.

ENDRELEASENOTES

Fixes #590
[x] Builds on #614
[x] Includes #623
[x] Needs #580 in order to make the edm4hep tests pass again
[x] Add an additional "legacy test file" for v0.99

This was originally done in #615. See there for a bit more discussion.

tmadlener commented 2 months ago

I agree, more documentation on this is necessary. Since, we also don't really have documentation on how we store collections, I would prefer a separate PR for the documentation. I can prepare that in parallel.

tmadlener commented 2 months ago

Documentation can be seen in #629, rendered by markdown here

jmcarcell commented 2 months ago

Something I found with this PR is that it fixes an issue I had only when making Debug builds with Clang 17. For some reason, the GenericParameters were not being saved in the file and all the tests for reading would fail. I picked up a working build of podio and read the files produced with this debug build and indeed the GenericParameters were not there. I never spent more time to figure out what was going on but out of all the build types and compilers (GCC and Clang) I only managed to reproduce it with Clang and -DCMAKE_BUILD_TYPE=Debug.