AIDASoft / podio

PODIO
GNU General Public License v3.0
23 stars 57 forks source link

Pass an argument by const reference instead of value and other minor fixes #633

Closed jmcarcell closed 2 months ago

jmcarcell commented 2 months ago

BEGINRELEASENOTES

ENDRELEASENOTES

tmadlener commented 2 months ago

Looks like CERNs infrastructure is slightly overwhelmed, CI is failing because we cannot get cvmfs or because fetching test data is failing.

m-fila commented 2 months ago

Another minor fix that could be added: this could be simiplified to just return m_obj https://github.com/AIDASoft/podio/blob/d12f4df81591e54e7750500f5d6ae70bad7ecc39/python/templates/macros/implementations.jinja2#L184-L189

tmadlener commented 2 months ago

Can you pick up the changes from #634 (i.e. merge / rebase onto latest master)? I think that should fix the remaining CI issues that we see.

jmcarcell commented 2 months ago

Can you pick up the changes from #634 (i.e. merge / rebase onto latest master)? I think that should fix the remaining CI issues that we see.

Done