search

AIDASoft / podio

PODIO
GNU General Public License v3.0
23 stars 57 forks source link

Make ROOT load libraries without the .so extension #638

Closed jmcarcell closed 1 month ago

jmcarcell commented 1 month ago

BEGINRELEASENOTES

ENDRELEASENOTES

See https://github.com/key4hep/EDM4hep/pull/339 and https://github.com/key4hep/EDM4hep/issues/338. This means no one is running the tests on MacOS :smile:

tmadlener commented 1 month ago

Well, maybe someone has, but they ignored the failing tests ;)

There is another error message with an explicit .so here:

https://github.com/AIDASoft/podio/blob/1fc075df881f1b4c58f7e85b53aecb14fcba1e24/python/podio/__init__.py#L10

jmcarcell commented 1 month ago

I don't have a mac handy to check but maybe it doesn't matter because of https://github.com/AIDASoft/podio/blob/1fc075df881f1b4c58f7e85b53aecb14fcba1e24/CMakeLists.txt#L52

tmadlener commented 1 month ago

Ah yes, that probably also affects mac OS builds. Not sure if mac OS still allows shared libs with .so ending though. Anyhow, for this PR it should not matter too much as long as ROOT does the "right thing".