AIDAVA-DEV / AIDAVA-Reference-Ontology

AIDAVA Reference Ontology
1 stars 0 forks source link

Add the parent class sphn:Measurement to the domain of sphn:hasMeasurementMethod #9

Closed KateSerafimova closed 6 months ago

KateSerafimova commented 8 months ago

Background

The Measurement class in SPHN has the following subclasses:

Blood Pressure, Heart Rate and Oxygen Saturation have a property sphn:hasMeasurementMethod with range Measurement Method, which is equivalent to SNOMED 122869004 | Measurement procedure (procedure).

In the data from partners (MUG, UM) there are data points that can be mapped to SNOMED concepts, that fall under SNOMED 122869004 | Measurement procedure (procedure):

Change Detail

Extend the domains of sphn:hasMeasurementMethod to sphn:Measurement, so that all measurements can have a measurement method.

Why is this change needed?

This will allow us to include more data points in the Measurement class and describe them in detail.

What is the impact if this change isn't made?

All the listed Subclasses and all entities of type Measurement will have the property hasMeasurementMethod.

rcelebi commented 8 months ago

In the new version of SPHN (2024 release candidate), sphn:hasMethodCode is added to sphn:Measurement, this property is a subproperty of sphn:hasCode and takes either sphn:Code or sphn:Terminology. The change details could be found in this document: https://git.dcc.sib.swiss/sphn-semantic-framework/sphn-schema/-/blob/release-candidate-2024-1/dataset/documentation-2024.1/Measurements_2024.1_final.pdf

rcelebi commented 8 months ago

At the meeting on December 21, 2023, we discussed the proposal from the SPHN 2024 candidate, which suggests a modification for this issue. The proposed change requires modifications to the entire Measurement class. We must review this proposal to ensure that the structure aligns with an upper-level ontology.

micheldumontier commented 7 months ago

The issue i have is that the new "Result" type should rather be a union of valid values stemming from the measurement process (procedure). For instance, it could be a numeric value, it could be a boolean value (presence/absence) of something, or it could be a descriptor.

todorprimov commented 6 months ago

Seems that the proper solution is to extend the domain coverage of the existing property, rather than to introduce new "specialized" property.

KateSerafimova commented 6 months ago

Changes

In AIDAVA:

+###  https://biomedit.ch/rdf/sphn-ontology/sphn#hasMeasurementMethod
+sphn:hasMeasurementMethod rdfs:domain [ rdf:type owl:Class ;
+                                        owl:unionOf ( sphn:BloodPressure
+                                                      sphn:HeartRate
+                                                      sphn:Measurement
+                                                      sphn:OxygenSaturation
+                                                    )
+                                      ] .
sphn:Measurement rdfs:subClassOf [ owl:intersectionOf ( [ rdf:type owl:Restricti
                                                         ]
                                                       ) ;
                                    rdf:type owl:Class
+                                 ] ,
+                                 [ owl:intersectionOf ( [ rdf:type owl:Restriction ;
+                                                          owl:onProperty sphn:hasMeasurementMethod ;
+                                                          owl:minCardinality "0"^^xsd:nonNegativeInteger
+                                                        ]
+                                                        [ rdf:type owl:Restriction ;
+                                                          owl:onProperty sphn:hasMeasurementMethod ;
+                                                          owl:maxCardinality "1"^^xsd:nonNegativeInteger
+                                                        ]
+                                                      ) ;
+                                   rdf:type owl:Class
                                  ] .

In SPHN subset file:

###  https://biomedit.ch/rdf/sphn-ontology/sphn#hasMeasurementMethod
 sphn:hasMeasurementMethod rdf:type owl:ObjectProperty ;
                           rdfs:subPropertyOf sphn:SPHNAttributeObject ;
-                          rdfs:domain [ rdf:type owl:Class ;
-                                        owl:unionOf ( sphn:BloodPressure
-                                                      sphn:HeartRate
-                                                      sphn:OxygenSaturation
-                                                    )
-                                      ] ;
                           rdfs:range sphn:MeasurementMethod ;
                           rdfs:comment "measurement method of the concept" ;
                           rdfs:label "has measurement method" ;