AILab-CVC / VideoCrafter

VideoCrafter2: Overcoming Data Limitations for High-Quality Video Diffusion Models
https://ailab-cvc.github.io/videocrafter2/
Other
4.58k stars 342 forks source link

A Bug in codes #49

Open Du-Yao opened 1 year ago

Du-Yao commented 1 year ago

Thanks for opening codes. However, I notice that some codes in VideoCrafter/lvdm/modules/attention.py have a few mistake. First, in Line 94 and Line 110, the relative position seems wrong. Then, in Line 123, I believe that "out_ip = rearrange(out, '(b h) n d -> b n (h d)', h=h" should be "out_ip = rearrange(out_ip, '(b h) n d -> b n (h d)', h=h".

Please authors check the code and fix them soon if they are bugs. Otherwise, I hope authors could explain this code. Thanks!