search

AIM-Harvard / SlicerRadiomics

A Slicer extension to provide a GUI around pyradiomics
BSD 3-Clause "New" or "Revised" License
101 stars 47 forks source link

COMP: Use https protocol for git by default #68

Closed jamesobutler closed 2 years ago

jamesobutler commented 2 years ago

This PR aims to solve current SlicerRadiomics build issue https://slicer.cdash.org/viewBuildError.php?buildid=2628696.

GitHub has disabled the unauthenticated git protocol by default (see https://github.blog/2021-09-01-improving-git-protocol-security-github).

Since most projects are hosted on GitHub, disable git protocol by default (and use https instead).

This is based on corresponding Slicer commit https://github.com/Slicer/Slicer/commit/99578c69edb147c9d0b517270803e30851fa7660.

cc: @JoostJM or @fedorov for review.

fedorov commented 2 years ago

Turns out, I do not have the permissions to merge this commit, now that the repo was migrated under a new org. Perhaps @hugoaerts can help here.

fedorov commented 2 years ago

Thanks to @hugoaerts for the quick response 👍 merging now.