search

AIM-Harvard / foundation-cancer-image-biomarker

Code and evaluation repository for the paper
https://aim-harvard.github.io/foundation-cancer-image-biomarker/
MIT License
83 stars 10 forks source link

Should the FMCIB model by default be in `eval` mode? #284

Closed surajpaib closed 6 months ago

surajpaib commented 9 months ago

For:

  1. It will most likely be used for inference.
  2. It eliminates users extracting wrong feature values accidentally

Against:

  1. Hidden behaviour. Might not be ideal to force eval mode
surajpaib commented 6 months ago

Fixed by https://github.com/AIM-Harvard/foundation-cancer-image-biomarker/blob/88d4bfa5964f89161b0a519491a095ec2a2fe923/fmcib/run.py#L49

Default for feature extraction is eval mode