AIM-Harvard / pyradiomics

Open-source python package for the extraction of Radiomics features from 2D and 3D images and binary masks. Support: https://discourse.slicer.org/c/community/radiomics
http://pyradiomics.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1.18k stars 498 forks source link

update setup.py with proper attribution and contact info #105

Closed pieper closed 8 years ago

pieper commented 8 years ago

@hugoaerts what do you want to have as the contact email? maybe a mailing list?

fedorov commented 8 years ago

related to updating setup.py in preparation for the public release, we should also consider if we plan to stop at feature extraction, or also address analysis.

If we do not plan to address analysis of the features, then perhaps "pyradiomics" is not the best name for this package.

hugoaerts commented 8 years ago

An general email would be great? Can we get a Github one? Maybe something like radiomics@github.com?? No idea if this is possible

Let's keep it at only feature extraction for now. let me explain at the next meeting why

We could consider to call it just 'radiomics', as the package is in python already, I dont see the need to add the 'py' to it. But lets discuss

pieper commented 8 years ago

I agree with dropping the 'py'. Maybe calling it RadiomicsFeatures would be the most accurate descriptor.

On Fri, Sep 9, 2016 at 11:35 AM, hugoaerts notifications@github.com wrote:

An general email would be great? Can we get a Github one? Maybe something like radiomics@github.com?? No idea if this is possible

Let's keep it at only feature extraction for now. let me explain at the next meeting why

We could consider to call it just 'radiomics', as the package is in python already, I dont see the need to add the 'py' to it. But lets discuss

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Radiomics/pyradiomics/issues/105#issuecomment-245949625, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHsfUDabnLqNS5faSkYG2BX5ng4t_8qks5qoXzTgaJpZM4J5HuC .

fedorov commented 8 years ago

if we keep the name at *radiomics, with the hope of expanding beyond just feature calculations in the future, I would prefer to keep "py" since this makes it obvious from the name that it is implemented in python, and there are some good precedents such as pydicom, pywt, many many others.

hugoaerts commented 8 years ago

There are also a lot of packages without ‘py’ in front of it . I always like to keep it as simple as possible

On Sep 9, 2016, at 12:03 PM, Andrey Fedorov notifications@github.com wrote:

if we keep the name at *radiomics, with the hope of expanding beyond just feature calculations in the future, I would prefer to keep "py" since this makes it obvious from the name that it is implemented in python, and there are some good precedents such as pydicom, pywt, many many others.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Radiomics/pyradiomics/issues/105#issuecomment-245958178, or mute the thread https://github.com/notifications/unsubscribe-auth/AMw_Ni7CkXCb9BfES18uSXToKQCBcRu8ks5qoYNggaJpZM4J5HuC.

fedorov commented 8 years ago

I agree there are examples on both sides. I just expressed my preference. By making it explicit from the name that this is a python package, you become automatically recognized as a member of the python community.

The name "radiomics" is too generic at this point though, either way we may want to be more specific to differentiate ourselves.

"Everything should be made as simple as possible, but not simpler." -- Albert Einstein

pieper commented 8 years ago

I always like it when people put py at the end of their package names, then you can have fun with different pronunciations. Like scipy and QtPy can become skippy and cutie-pie! : D

On Fri, Sep 9, 2016 at 12:47 PM, Andrey Fedorov notifications@github.com wrote:

I agree there are examples on both sides. I just expressed my preference. By making it explicit from the name that this is a python package, you become automatically recognized as a member of the python community.

The name "radiomics" is too generic at this point though, either way we may want to be more specific to differentiate ourselves.

"Everything should be made as simple as possible, but not simpler." -- Albert Einstein

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Radiomics/pyradiomics/issues/105#issuecomment-245970572, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHsfeUhZkLWiNo03l335QoiZu5osZygks5qoY2mgaJpZM4J5HuC .

fedorov commented 8 years ago

Now that we have all the options and opinions on the table, I will let Hugo make the pick!

Not sure I am a fan of radiomicsPy, but I think "roPy" has a fair shot at becoming skippy :-D

hugoaerts commented 8 years ago

Lets discuss it next Wednesday

On Sep 9, 2016, at 1:33 PM, Andrey Fedorov notifications@github.com wrote:

Now that we have all the options and opinions on the table, I will let Hugo make the pick!

Not sure I am a fan of radiomicsPy, but I think "roPy" has a fair shot at becoming skippy :-D

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Radiomics/pyradiomics/issues/105#issuecomment-245983224, or mute the thread https://github.com/notifications/unsubscribe-auth/AMw_Nqk8cfqPttNsQvTiDiEjkLPANbbcks5qoZhdgaJpZM4J5HuC.

naucoin commented 8 years ago

Looking at updating setup.py as I finalise installation instructions, what do we want for the author and author_email fields? name is still currently set to pyradiomics. Proposed: https://github.com/naucoin/pyradiomics/commit/b5dc11827e4f737f83e55c26900a3ba437de9b8d

fedorov commented 8 years ago

I suggest we create a user group on google groups and list there that group email, and put "pyradiomics community" as the author. What do we have as a contact for Slicer? Let's not finalize this until we discuss with Hugo at the next call.

JoostJM commented 8 years ago

I suggest we create a user group on google groups

@fedorov You already did that, here, see also #58

fedorov commented 8 years ago

Thanks for the reminder! @naucoin I suggest we use that group list as contact.

JoostJM commented 8 years ago

Resolved by #136