AIM-Harvard / pyradiomics

Open-source python package for the extraction of Radiomics features from 2D and 3D images and binary masks. Support: https://discourse.slicer.org/c/community/radiomics
http://pyradiomics.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1.14k stars 492 forks source link

Consider using mybinder #275

Open fedorov opened 7 years ago

fedorov commented 7 years ago

See https://beta.mybinder.org/

fedorov commented 7 years ago

Currently building of the binder is failing due to #276

jcfr commented 7 years ago

If I recall, binder is not maintained anymore.

Cc: @thewtex

pieper commented 7 years ago

It's not currently working for me (constant spinning logo and server error in the browser console).

On Mon, Jul 17, 2017 at 1:17 PM, Jean-Christophe Fillion-Robin < notifications@github.com> wrote:

If I recall, binder is not maintained anymore.

Cc: @thewtex https://github.com/thewtex

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Radiomics/pyradiomics/issues/275#issuecomment-315820126, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHsfd-8KRqP-GoXt3WjZjJPbfiQcRSUks5sO5cggaJpZM4OaQOp .

jcfr commented 7 years ago

If you check the status, it is down: http://mybinder.org/status

@thewtex should be able to confirm, but if i recall they run out of funding. The model was not sustainable ( to be confirmed)

fedorov commented 7 years ago

See the URL I included in the initial post ;-)

fedorov commented 7 years ago

cc: @yuvipanda

fedorov commented 7 years ago

Working example: https://github.com/minrk/ligo-binder and direct binder url https://beta.mybinder.org/v2/gh/minrk/ligo-binder/master?filepath=index.ipynb

jcfr commented 7 years ago

Indeed, there are mybinder.org and beta.mybinder.org

I just wonder what is backing up beta.mybinder.org.

On Jul 17, 2017 1:24 PM, "Andrey Fedorov" notifications@github.com wrote:

See the URL I included in the initial post ;-)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Radiomics/pyradiomics/issues/275#issuecomment-315822107, or mute the thread https://github.com/notifications/unsubscribe-auth/AANXo_3NgancuNeqK6Idy6JR9v4jyT-0ks5sO5i8gaJpZM4OaQOp .

pieper commented 7 years ago

@fedorov your original post didn't link to a working example!

fedorov commented 7 years ago

indeed. What I meant to imply in an awkward manner is that I was not referring to http://mybinder.org. https://beta.mybinder.org/ can presumably be used for any repo that has a python notebook, so I was not sure what exactly was not working and timed out from https://beta.mybinder.org/.

yuvipanda commented 7 years ago

Heya! Me and @choldgraf and others from the Jupyter Project have started assisting mybinder, and rewrote it to run on top of JupyterHub. beta.mybinder.org is the newer version, and should be a lot more stable (and we're committed to supporting it, and have structural support to doing so). The long term hope is that we make it really easy for institutions, publications and organizations to set up their own binder install, so people can use the same compatible repositories on any of them.

Am happy to help answer any other questions!

pieper commented 7 years ago

Thanks for the info @yuvipanda! This will be very helpful.

thewtex commented 7 years ago

@yuvipanda That is fantastic to hear! For organizations that do not have the resources to set up their own JupyterHub instance, how many resources are available and how long will they be available for?

choldgraf commented 7 years ago

+1 to what Yuvi said!

To @thewtex's question, Binder is a space that's evolving relatively rapidly right now so it's hard to say exactly what resources etc are available. That said, there's definitely a lot of interest in making the platform as easy as possible to deploy on other servers etc, and also a lot of interest in keeping the public mybinder.org service running as a public good. Feel free to open an issue over on the binderhub repo if there's a specific configuration setup you're concerned about (https://github.com/jupyterhub/binderhub)

JoostJM commented 7 years ago

Using the branch from #285, I was able to build and launch using MyBinder. This required some changes to the dockerfile, as 3 notebooks are run as part of the build process, which assume a certain structure of the files and folders.

JoostJM commented 7 years ago

This is the link to the image.

choldgraf commented 7 years ago

just a quick thought - Binder now supports new features of repo2docker, including the ability to run shell scripts prior to generating the Docker image. So if you'd like to handle pre-build stuff with scripts instead of a Dockerfile, that should be possible now!

JoostJM commented 7 years ago

link to the image build upon radiomics/pyradiomics/master

fedorov commented 7 years ago

FYI another free cloud-based notebook hosting platform: https://notebooks.azure.com

Disadvantages:

Advantages:

choldgraf commented 7 years ago

FWIW, Binder is actively supported as well ;-) (this wasn't true 9 months ago but it's a jupyter project now)

Also I'm curious what you mean by "more robust"?

(full disclosure: I'm on the jupyter team and working on the binder project :-) )

fedorov commented 7 years ago

@choldgraf sorry, I didn't mean to offend you! I have a lot of respect to Binder, and it has some significant advantages!

What I meant by "actively supported" is that is has Microsoft and Azure backing it, so there is a clear entity with deep pockets paying for the cloud cycles. I also liked that there is a timeline with updates which seems to be updated quite often. With Binder, documentation seems to be quite dispersed, it is not clear how to do things beyond the example binders, and what is going on with the development. It was also confusing to me as a beginner to find my way around (I have not tried very hard, I admit) the soup of terms "binder", "beta binder", "jupyter hub", "docker2repo" - it is quite hard to understand how to navigate this and what is going on. BUT (and that's a HUGE "but"!!!) once I get something that "just works" - I am pretty happy - as long as it works - and I don't care that much how and why it works.

About robustness - I was referring to the discussion we had on gitter with @minrk. Yesterday I had a mysterious failure to launch, with no error messages, which you guys seemed to have traced down to github throttling due to lack of OAuth integration. @minrk seemed to suggest that with the Azure Notebooks there would be no problems loading (and that's understandable given how much resources MS has).

choldgraf commented 7 years ago

absolutely not offended :-) just trying to figure out where binder isn't meeting expectations so that we can figure out if/how we should try to improve things!

I totally agree about all the issues you just noted - some of them are just because the tech behind Binder is definitely still in a beta state...this stuff didn't exist in its current form > 4 months ago :-) if there's something in particular that's confusing etc in the documentation, don't hesitate to open an issue in the binder or binderhub repos. One of our next focuses is to build up the documentation.

fedorov commented 7 years ago

@choldgraf I think a good start would be to add a link to the documentation / "getting started" / examples to the front page: https://beta.mybinder.org/. It is quite confusing that the front page does not have any pointer to the documentation!

choldgraf commented 7 years ago

that's a good point! I agree that should be posted there...

FWIW, here are the docs we'll iterate on for the beta deployment: http://mybinder.readthedocs.io/en/latest/