You do not have to request changes when it is a small thing like naming or docstrings. I normally just added the comments and approve the PR. Then I trust that the PR author will consider the comments and do small changes if necessary. The author can then just merge the PR without waiting for new approval.
So I normally use.
Request change: You have to change this before we accept the PR.
Approve with comments: Please consider changing this thing before merging.
@eyhl
You do not have to request changes when it is a small thing like naming or docstrings. I normally just added the comments and approve the PR. Then I trust that the PR author will consider the comments and do small changes if necessary. The author can then just merge the PR without waiting for new approval.
So I normally use.