search

AIS-Bonn / nimbro_network

ROS network stack: Topic/service transport over unreliable network connections
BSD 3-Clause "New" or "Revised" License
138 stars 42 forks source link

Wrong catch_ros include dir in certain situations #19

Open xqms opened 3 years ago

xqms commented 3 years ago

As discovered in https://github.com/AIS-Bonn/catch_ros/pull/15, we currently prefer the catch_ros headers from e.g. /opt/ros/noetic/include in favor of the (correct) ones from the current workspace.

The reason is this line: https://github.com/AIS-Bonn/nimbro_network/blob/7e1de20c8fb33fb1bf22ab9a8c4e93d098b9c4a3/nimbro_topic_transport/CMakeLists.txt#L170

... which adds the catch_ros headers to the end. Instead, we should use catkin's list_insert_in_workspace_order() function to correctly insert the additional include path.