Calc Feedback

[olirob93]

Requirements

• Deployed website - yes
• Github Repo:
  • README.md - sort of
  • 15 commits - yes
• Be responsive and built mobile-first, it should work on different screen widths - yes
• Accept a minimum of 2 inputs, perform an operation and return the output.- yes
• DO NOT USE eval() - yes
• Code is highly readable (good naming and indented correctly)

Lets Build

• A working Calculator
• Practice using Git and GitHub flow
• Apply what you are learning?
  • SCSS
  • BEM

Score

MARKING-SCHEME

Category	Score
Version Control	10/ 10
Site Output	25/ 45
Readability	10/ 20
Responsiveness	10/ 10
Code Knowledge & Use	25/ 25
Total Score	80/ 110

Notes

Nice work on this project the HTML is clear and laid out nicely and your SCSS and BEM styling is good. Your Typescript is named well and is built up of various functions.

There are a few bugs in here such as not being able to do anything with negative numbers. Also i'm not 100% sure which is your final branch as there is no typescript on main? I used the ts-branch for marking.

The UI

Positive

• Looks good across all devices
• I like the writting coming across at the beggining

Constructive

• Try to remove the NaN error from the output box
• you get a double decimal when you press it

The Code

Positive

• Good naming convention on the functions
• Lots of commits and used branches!!

Constructive

• You have not successfully pushed your final code into main, I assume it is on the TS-branch. Also, there is lots of console logs on this branch. When you push to main we want to keep this branch as clean as possible.
• It would be good to see you explicitly say what some of the types are when using typescript for example to show you understand what they are for example

let num1input: string = "";
let total : number = 0;

Try to lay your code out clearer moving forward into these type of sections imports at the very top variables next query selectors Any functions any loops/ event listeners at the bottom

• you also have a main.css, this shouldn't exist anymore as we are no longer using the watch sass we installed the sass dependency.

[AISimonetta]

Thank you Ollie! I will make the changes as soon as I can and consider all the recommendations for the next project :)