Closed wallner90 closed 1 year ago
@wallner90 Just recalled that we need to check the order of topics. The synchronization filters are created as a dict (topic: filter) and whatever order comes out of it will be the order of the message, which may conflict with the order on the command line. Besides the sync_filters are first checked on presence in the meta-data of the bag, which also may have a different order.
From Python 3.7 onward dictionaries are ordered in insertion order: https://docs.python.org/3.7/tutorial/datastructures.html#dictionaries
Currently (humble onwards) only RHEL requires support for a version < 3,7.
So for less compatibility issues, I suggest first creating the Async-Filters as a list based on args.topics, then the sychronizer and then creating a dict of them (zip(args.topic, filters)) as before.
@Kettenhoax LGTM!
Still one change open.
Done!
LGTM!
Added option to unify all written files to use the timestamp of the first given topic.