search

AIT-Assistive-Autonomous-Systems / ros2bag_tools

Tool extensions for ros2bag cli
122 stars 34 forks source link

Add compressed image export support #2

Closed devrite closed 2 years ago

devrite commented 2 years ago

Adds compressed support and fix help formatting error.

devrite commented 2 years ago

@Kettenhoax Added the necessary changes and (some changes that would fail the current tests).

I locally tested it with a compressed and not compressed. At first glance it does not recode if it is the same compressed format. It does not convert if it is the same format and does produce the error if the forced encoding does not match the determined input encoding in size.

We could add some automatic tests before merging resp. you could also check it on your side. Or we add them later.

Kettenhoax commented 2 years ago

I've tested export of raw bayer, raw bgr8 images, chosen demosaicing and export of compressed images w and w/o encoding conversion.

Works well, awesome work!