Fix read order error in reader.py for export

AIT-Assistive-Autonomous-Systems / ros2bag_tools

Tool extensions for ros2bag cli

122 stars 34 forks source link

Fix read order error in reader.py for export #28

Closed pablogago11 closed 11 months ago

pablogago11 commented 11 months ago

Hi all,

Great work your rosbag tools! Used your package to export the Point Clouds from a rosbag to PCD files and found a bug related to the set_read_order() function inside reader.py (line 75)

I think it all comes from this fix #1177 from the rosbag2 repository. There was a thrown error: read order can only be set after open() related to what they comment on the issue so my solution was to just comment the whole if loop (line 74 to 76) and your tool perfectly worked!

Best!

devrite commented 11 months ago

Hi pablo,

right, had no time to fix it yet and upon implementation read order was not released yet. Happy to review a pull request, should you have time todo it before me.

BR,

Markus