AIforGoodSimulator / model-server

MIT License
11 stars 9 forks source link

Advanced ui pre-access control update #156

Closed pardf closed 3 years ago

pardf commented 3 years ago
pardf commented 3 years ago

Hi @kariso2000 could you check why the unit check fails after update of .env,default?

ValueError: Redis URL must specify one of the following schemes (redis://, rediss://, unix://)

Perhaps the secrets of dev needs to be updated?

kariso2000 commented 3 years ago

Hi @pardf - This is failing due to missing .env file. I think we should refactor the redis code so that local dev and CI only use flask cache.

pardf commented 3 years ago

Hi @pardf - This is failing due to missing .env file. I think we should refactor the redis code so that local dev and CI only use flask cache.

Thanks @kariso2000 but we need to put in the .env file anyway into the dev? There may be features used in Redis not supported or compatible with Flask cache

Alternatively, we need to continue to use Redis cache with .env

kariso2000 commented 3 years ago

@pardf Just to confirm this failure is not on dev as the pull request has not taken place. This is happening in the CI pipeline in github. I saw on https://flask-caching.readthedocs.io/en/latest/ that it does not mention that FileSystemCache is not thread safe. Do you think we can use this instead ?

kariso2000 commented 3 years ago

@pardf Due to other code dependancies we cannot use FileSystemCache. However for the CI run we can implement - https://docs.github.com/en/free-pro-team@latest/actions/guides/creating-redis-service-containers.

I'll get this set up.