Closed billlyzhaoyh closed 3 years ago
Code changes for parameter loading in Compartmental model break ABM tests. Need to change the test now to read from local test files since the models wouldn't have the input parameters available until there is user input. Might be a good time to revise the testing suite for all three models.
The infection number is broken due to population vector change and that will be fixed soon. Next step is to set the compartmental model profiles dynamically in a script so it scales with population number or else ode solver can mysteriously break due to some ill conditions imposed by the profile. For example, trying to remove residents at high risk at 30 people/day but then there are not many residents at high risk thus resulting in a negative number
@billlyzhaoyh could we do smaller PR in future as it would be easier to review and comment, etc.? Thanks
Waiting page needs to be updated but can be revised later
Noted that the session id is set to a fixed number for reading in the InputParameterCache but that will change once the data segregation is done.
There are still a few awkward implementations here: