search

AIrjen / OneButtonPrompt

One Button Prompt
GNU General Public License v3.0
875 stars 87 forks source link

[ComfyUI] - Same seed produces random prompts #130

Closed kex0 closed 1 year ago

kex0 commented 1 year ago

I'm using ComfyUI

Issue:

"One Button Prompt" node I'm feeding it a fixed integer seed but whenever I restart ComfyUI and use the same exact workflow with all settings exactly the same including the seed, the resulting prompt is completely different.

Expected behaviour:

"One Button Prompt" node should produce exactly the same prompt every single time when the seed and other parameters are the same.

Example workflow: seed_issue.zip

Before restart chrome_0UYo6mpEjL

After restart chrome_zhCGB7IIEU

Thank you. I love these custom nodes but this one issue makes it pretty unusable for me.

AIrjen commented 1 year ago

Thats not how it works!

Basically the seed on the ComfyUI node is a hack to ensure it is triggered after each run. It doesn’t actually use the seed for anything. It is a workaround for how ComfyUI works.

Without it, it would trigger only once and keep the same prompt until restart.

AIrjen commented 1 year ago

I am looking at your PR! I can see why that would work. Was on my phone earlier, so I didn't see it.

AIrjen commented 1 year ago

Made some changes in your PR. Yours would break the A1111 integration. Moved some stuff around.

Thanks! Smart idea and a good implementation.